Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/usrsctp/BUILD.gn

Issue 1307223010: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/usrsctp/BUILD.gn
diff --git a/third_party/usrsctp/BUILD.gn b/third_party/usrsctp/BUILD.gn
index bbea24b858fea7de37599c9a6345f7a2f7ea2763..ee77057109045df60bc449ae6838c2abbda6dcea 100644
--- a/third_party/usrsctp/BUILD.gn
+++ b/third_party/usrsctp/BUILD.gn
@@ -11,6 +11,13 @@ config("usrsctp_config") {
]
}
+config("usrsctp_warnings") {
+ if (is_clang) {
+ # atomic_init in user_atomic.h is a static function in a header.
+ cflags = [ "-Wno-unused-function" ]
+ }
+}
+
static_library("usrsctp") {
sources = [
"usrsctplib/netinet/sctp.h",
@@ -84,16 +91,15 @@ static_library("usrsctp") {
# "SCTP_DEBUG", # Uncomment for SCTP debugging.
]
- config("usrsctp_warnings") {
- if (is_clang) {
- # atomic_init in user_atomic.h is a static function in a header.
- cflags = [ "-Wno-unused-function" ]
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ "//build/config/compiler:no_incompatible_pointer_warnings" ]
- configs += [ ":usrsctp_warnings" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+
+ # These must be after no_chromium_code for warning flags to be ordered
+ # correctly.
+ "//build/config/compiler:no_incompatible_pointer_warnings",
+ ":usrsctp_warnings",
+ ]
public_configs = [ ":usrsctp_config" ]
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698