Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/hunspell/BUILD.gn

Issue 1307223010: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/hunspell/BUILD.gn
diff --git a/third_party/hunspell/BUILD.gn b/third_party/hunspell/BUILD.gn
index 9e9f249e5b31b59ee0ca12a8768d4e9db942da67..87f5aec1373cc8ee56ae4f1f9f94e4dc23ee672c 100644
--- a/third_party/hunspell/BUILD.gn
+++ b/third_party/hunspell/BUILD.gn
@@ -10,6 +10,12 @@ config("hunspell_config") {
]
}
+config("hunspell_warnings") {
+ if (is_clang) {
+ cflags = [ "-Wno-unused-private-field" ]
+ }
+}
+
source_set("hunspell") {
sources = [
"google/bdict.cc",
@@ -51,15 +57,11 @@ source_set("hunspell") {
"src/parsers/textparser.hxx",
]
- config("hunspell_warnings") {
- if (is_clang) {
- cflags = [ "-Wno-unused-private-field" ]
- }
- }
-
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
"//build/config/compiler:no_chromium_code",
+
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
":hunspell_warnings",
]
public_configs = [ ":hunspell_config" ]
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698