Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: third_party/mesa/BUILD.gn

Issue 1307223010: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/lzma_sdk/BUILD.gn ('k') | third_party/snappy/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mesa/BUILD.gn
diff --git a/third_party/mesa/BUILD.gn b/third_party/mesa/BUILD.gn
index 052401f2b99b11e51b6989f5de988008454a203f..58cb60c0d51a696b09c0cd80334a0ccf6634504b 100644
--- a/third_party/mesa/BUILD.gn
+++ b/third_party/mesa/BUILD.gn
@@ -148,6 +148,15 @@ config("mesa_internal_warnings") {
}
}
+config("mesa_libglslcommon_warnings") {
+ if (is_clang) {
+ cflags = [
+ # https://bugs.freedesktop.org/show_bug.cgi?id=91645:
+ "-Wno-overloaded-virtual",
+ ]
+ }
+}
+
static_library("mesa_libglslcommon") {
sources = [
"$generated_src_dir/mesa/glcpp-lex.c",
@@ -252,15 +261,6 @@ static_library("mesa_libglslcommon") {
"src/src/glsl/strtod.h",
]
- config("mesa_libglslcommon_warnings") {
- if (is_clang) {
- cflags = [
- # https://bugs.freedesktop.org/show_bug.cgi?id=91645:
- "-Wno-overloaded-virtual",
- ]
- }
- }
-
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
previous_configs = configs
« no previous file with comments | « third_party/lzma_sdk/BUILD.gn ('k') | third_party/snappy/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698