Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: third_party/cld_2/BUILD.gn

Issue 1307223010: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/brotli/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cld_2/BUILD.gn
diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn
index fc42c4fbb48b14e4ae9d1cab582408752a0167af..bd3a181e5d7d33c17aede02de7795cd4dd2325c6 100644
--- a/third_party/cld_2/BUILD.gn
+++ b/third_party/cld_2/BUILD.gn
@@ -33,6 +33,14 @@ cld2_platform_support = "static"
cld2_table_size = 2
+config("cld2_data_warnings") {
+ visibility = [ ":*" ]
+ if (is_clang) {
+ # The generated files don't have braces around subobject initializers.
+ cflags = [ "-Wno-missing-braces" ]
+ }
+}
+
source_set("cld2_data") {
sources = gypi_values.cld2_data_sources
if (cld2_table_size == 0) {
@@ -46,15 +54,13 @@ source_set("cld2_data") {
"src/public",
]
- config("cld2_data_warnings") {
- if (is_clang) {
- # The generated files don't have braces around subobject initializers.
- cflags = [ "-Wno-missing-braces" ]
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ ":cld2_data_warnings" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
+ ":cld2_data_warnings",
+ ]
}
# As in the corresponding gyp file, this just builds the core interfaces for
« no previous file with comments | « third_party/brotli/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698