Added a version of the v8::HandleScope constructor with an Isolate and use that consistently.

Added a version of the v8::HandleScope constructor with an Isolate and use that consistently.

I tried to limit the use of v8::Isolate::GetCurrent() and v8::internal::Isolate::Current() as much as possible, but sometimes this would have involved restructuring tests quite a bit, which is better left for a separate CL.

BUG=v8:2487
Committed: http://code.google.com/p/v8/source/detail?r=13953

[Michael Starzinger, 2013-03-14 19:10:26]

LGTM, only one real comment.

https://codereview.chromium.org/12716010/diff/2001/samples/shell.cc
File samples/shell.cc (right):

https://codereview.chromium.org/12716010/diff/2001/samples/shell.cc#newcode75
samples/shell.cc:75: v8::HandleScope handle_scope(isolate);
Why was this HandleScope moved down? I think it should include the call to
CreateShellContext.

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3477: LocalContext context;
Here the LocalContext is available, move it up and use it's context.

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3821: LocalContext context;
Likewise.

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3834: LocalContext context;
Likewise, and several occurrences below.

[Sven Panne, 2013-03-15 07:59:09]

Feedback addressed, landing...

https://codereview.chromium.org/12716010/diff/2001/samples/shell.cc
File samples/shell.cc (right):

https://codereview.chromium.org/12716010/diff/2001/samples/shell.cc#newcode75
samples/shell.cc:75: v8::HandleScope handle_scope(isolate);
On 2013/03/14 19:10:26, Michael Starzinger wrote:
> Why was this HandleScope moved down? I think it should include the call to
> CreateShellContext.

Done. Ceterum censeo shell.cc esse delendam! :-P

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3477: LocalContext context;
On 2013/03/14 19:10:26, Michael Starzinger wrote:
> Here the LocalContext is available, move it up and use it's context.

Done.

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3821: LocalContext context;
On 2013/03/14 19:10:26, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/12716010/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:3834: LocalContext context;
On 2013/03/14 19:10:26, Michael Starzinger wrote:
> Likewise, and several occurrences below.

Done.

[Sven Panne, 2013-03-15 12:07:19]

Committed patchset #3 manually as r13953 (presubmit successful).