src/d8.h - Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.h

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Feedback. Rebased Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.h

diff --git a/src/d8.h b/src/d8.h

index 04c54545516b372c2b6d4471a72a9f026f34dfb5..621ac74095b960c99e61ae056ed697b92233d999 100644

--- a/src/d8.h

+++ b/src/d8.h

@@ -265,12 +265,13 @@ class Shell : public i::AllStatic {

#endif // V8_SHARED

public:

- static bool ExecuteString(Handle<String> source,

+ static bool ExecuteString(Isolate* isolate,

+ Handle<String> source,

Handle<Value> name,

bool print_result,

bool report_exceptions);

static const char* ToCString(const v8::String::Utf8Value& value);

- static void ReportException(TryCatch* try_catch);

+ static void ReportException(Isolate* isolate, TryCatch* try_catch);

static Handle<String> ReadFile(Isolate* isolate, const char* name);

static Persistent<Context> CreateEvaluationContext(Isolate* isolate);

static int RunMain(Isolate* isolate, int argc, char* argv[]);

@@ -279,7 +280,8 @@ class Shell : public i::AllStatic {

static void OnExit();

#ifndef V8_SHARED

- static Handle<Array> GetCompletions(Handle<String> text,

+ static Handle<Array> GetCompletions(Isolate* isolate,

+ Handle<String> text,

Handle<String> full);

static int* LookupCounter(const char* name);

static void* CreateHistogram(const char* name,

« no previous file with comments | « src/api.cc ('k') | src/d8.cc » ('j') | no next file with comments »