Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: test/cctest/test-threads.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback. Rebased Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-thread-termination.cc ('k') | test/cctest/test-weakmaps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-threads.cc
diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc
index ffb29cdd25feb8f338c496f20b07c972df26ac56..5a010a8c9f1a5fa05b5dc5b56dc58cb540c9a43c 100644
--- a/test/cctest/test-threads.cc
+++ b/test/cctest/test-threads.cc
@@ -36,7 +36,7 @@
TEST(Preemption) {
v8::Locker locker(CcTest::default_isolate());
v8::V8::Initialize();
- v8::HandleScope scope;
+ v8::HandleScope scope(CcTest::default_isolate());
v8::Context::Scope context_scope(v8::Context::New());
v8::Locker::StartPreemption(100);
@@ -68,7 +68,7 @@ class ThreadA : public v8::internal::Thread {
ThreadA() : Thread("ThreadA") { }
void Run() {
v8::Locker locker(CcTest::default_isolate());
- v8::HandleScope scope;
+ v8::HandleScope scope(CcTest::default_isolate());
v8::Context::Scope context_scope(v8::Context::New());
CHECK_EQ(FILL_CACHE, turn);
@@ -107,7 +107,7 @@ class ThreadB : public v8::internal::Thread {
{
v8::Locker locker(CcTest::default_isolate());
if (turn == CLEAN_CACHE) {
- v8::HandleScope scope;
+ v8::HandleScope scope(CcTest::default_isolate());
v8::Context::Scope context_scope(v8::Context::New());
// Clear the caches by forcing major GC.
« no previous file with comments | « test/cctest/test-thread-termination.cc ('k') | test/cctest/test-weakmaps.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698