src/debug.cc - Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Feedback. Rebased Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 282157810cf8be58ae0d22a4506cf4743c3df6dc..1fd3e4023d8a16ec8364d0d42ba5dd3a915f5e38 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -3567,7 +3567,8 @@ v8::Handle<v8::Object> MessageImpl::GetEventData() const {

v8::Handle<v8::String> MessageImpl::GetJSON() const {

- v8::HandleScope scope;

+ v8::HandleScope scope(

+ reinterpret_cast<v8::Isolate*>(event_data_->GetIsolate()));

if (IsEvent()) {

// Call toJSONProtocol on the debug event object.

« no previous file with comments | « src/d8-readline.cc ('k') | src/factory.cc » ('j') | no next file with comments »