Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: test/cctest/test-alloc.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback. Rebased Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-accessors.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-alloc.cc
diff --git a/test/cctest/test-alloc.cc b/test/cctest/test-alloc.cc
index 8cabd3d9e93b5efaae849dff93aa63f1b503e568..d71247c500976eb68c0ee1cc724e8a2d5b34f7bd 100644
--- a/test/cctest/test-alloc.cc
+++ b/test/cctest/test-alloc.cc
@@ -96,7 +96,7 @@ static Handle<Object> Test() {
TEST(StressHandles) {
v8::Persistent<v8::Context> env = v8::Context::New();
- v8::HandleScope scope;
+ v8::HandleScope scope(env->GetIsolate());
env->Enter();
Handle<Object> o = Test();
CHECK(o->IsSmi() && Smi::cast(*o)->value() == 42);
@@ -118,7 +118,7 @@ const AccessorDescriptor kDescriptor = {
TEST(StressJS) {
v8::Persistent<v8::Context> env = v8::Context::New();
- v8::HandleScope scope;
+ v8::HandleScope scope(env->GetIsolate());
env->Enter();
Handle<JSFunction> function =
FACTORY->NewFunction(FACTORY->function_string(), FACTORY->null_value());
« no previous file with comments | « test/cctest/test-accessors.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698