chrome/browser/notifications/platform_notification_service_impl.cc - Issue 1269923003: Plumb notification action index for desktop SW notificationclick

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1269923003: Plumb notification action index for desktop SW notificationclick (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@actions

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.h ('k') | content/browser/notifications/notification_event_dispatcher_impl.h » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index 50a3430c7d5f25a02a3006593ceb9e1bb3b814e3..55815d873333ca48c471105923031f2aeab1dbc4 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -85,13 +85,15 @@ PlatformNotificationServiceImpl::~PlatformNotificationServiceImpl() {}

void PlatformNotificationServiceImpl::OnPersistentNotificationClick(

BrowserContext* browser_context,

int64_t persistent_notification_id,

- const GURL& origin) const {

+ const GURL& origin,

+ int action_index) const {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

content::NotificationEventDispatcher::GetInstance()

->DispatchNotificationClickEvent(

browser_context,

persistent_notification_id,

origin,

+ action_index,

base::Bind(&OnEventDispatchComplete));

}