Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly pass -Wno-unused-function to the targets that need it. Currently, it's disabled globally, but that'll hopefully change soon. No intended behavior change. BUG=505316 Committed: https://crrev.com/b2105710d8eab709b51cd3c5a5d974eb544d16d5 Cr-Commit-Position: refs/heads/master@{#344097}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : sup #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : gn #

Patch Set 7 : gnnnn #

Patch Set 8 : format #

Patch Set 9 : disable only #

Patch Set 10 : gnnnnnnnnnnn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -37 lines) Patch
M third_party/brotli/BUILD.gn View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/brotli/brotli.gyp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/libusb/BUILD.gn View 1 2 3 4 5 6 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/libusb/libusb.gyp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libxml/BUILD.gn View 1 2 3 4 5 6 1 chunk +20 lines, -19 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libxslt/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +13 lines, -4 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/snappy/BUILD.gn View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/snappy/snappy.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/usrsctp/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/yasm/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +9 lines, -3 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 4 months ago (2015-08-18 22:44:32 UTC) #2
dcheng
lgtm
5 years, 4 months ago (2015-08-18 23:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269293003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269293003/170001
5 years, 4 months ago (2015-08-18 23:54:36 UTC) #5
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 4 months ago (2015-08-19 00:29:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 00:29:51 UTC) #7
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/b2105710d8eab709b51cd3c5a5d974eb544d16d5
Cr-Commit-Position: refs/heads/master@{#344097}

Powered by Google App Engine
This is Rietveld 408576698