Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/brotli/BUILD.gn

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/brotli/brotli.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/brotli/BUILD.gn
diff --git a/third_party/brotli/BUILD.gn b/third_party/brotli/BUILD.gn
index 8e1c111260ed150101d2049508fe6ce1e5d5f095..2975f036df401585fe627b329471ad62c7bc65e9 100644
--- a/third_party/brotli/BUILD.gn
+++ b/third_party/brotli/BUILD.gn
@@ -23,8 +23,17 @@ source_set("brotli") {
"dec/types.h",
]
+ config("brotli_warnings") {
+ if (is_clang) {
+ # IncrementalCopyFastPath in decode.c can be unused.
+ # (The file looks very different upstream, this is probably no longer
+ # needed after rolling brotli the next time.)
+ cflags = [ "-Wno-unused-function" ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":brotli_warnings" ]
# Since we are never debug brotli, freeze the optimizations to -O2.
if (is_debug) {
« no previous file with comments | « no previous file | third_party/brotli/brotli.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698