Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/yasm/yasm.gyp

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/yasm/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/yasm.gyp
diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp
index 1f963a383e05c5ca0cf4920a037f5f6c580957b4..3db601a83f6a7750e0f14038b20704698210ad34 100644
--- a/third_party/yasm/yasm.gyp
+++ b/third_party/yasm/yasm.gyp
@@ -558,8 +558,13 @@
'-std=gnu99',
],
'variables': {
+ 'clang_warning_flags': [
# re2c is missing CLOSEVOP from one switch.
- 'clang_warning_flags': [ '-Wno-switch' ],
+ '-Wno-switch',
+ # re2c contains many static functions in headers (because it's
+ # a C library predating C99.)
+ '-Wno-unused-function',
+ ],
},
'msvs_disabled_warnings': [ 4267 ],
},
« no previous file with comments | « third_party/yasm/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698