Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: third_party/snappy/snappy.gyp

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/snappy/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 # Define an "os_include" variable that points at the OS-specific generated 8 # Define an "os_include" variable that points at the OS-specific generated
9 # headers. These were generated by running the configure script offline. 9 # headers. These were generated by running the configure script offline.
10 ['os_posix == 1 and OS != "mac"', { 10 ['os_posix == 1 and OS != "mac"', {
(...skipping 13 matching lines...) Expand all
24 'src', 24 'src',
25 '../..', 25 '../..',
26 ], 26 ],
27 'direct_dependent_settings': { 27 'direct_dependent_settings': {
28 'include_dirs': [ 28 'include_dirs': [
29 '<(os_include)', 29 '<(os_include)',
30 'src', 30 'src',
31 ], 31 ],
32 }, 32 },
33 'variables': { 33 'variables': {
34 'clang_warning_flags': [
35 # ComputeTable is unused,
36 # https://code.google.com/p/snappy/issues/detail?id=96
37 '-Wno-unused-function',
38 ],
34 'clang_warning_flags_unset': [ 39 'clang_warning_flags_unset': [
35 # snappy-stubs-internal.h unapologetically has: using namespace std 40 # snappy-stubs-internal.h unapologetically has: using namespace std
36 # https://code.google.com/p/snappy/issues/detail?id=70 41 # https://code.google.com/p/snappy/issues/detail?id=70
37 '-Wheader-hygiene', 42 '-Wheader-hygiene',
38 ], 43 ],
39 }, 44 },
40 'sources': [ 45 'sources': [
41 'src/snappy-internal.h', 46 'src/snappy-internal.h',
42 'src/snappy-sinksource.cc', 47 'src/snappy-sinksource.cc',
43 'src/snappy-sinksource.h', 48 'src/snappy-sinksource.h',
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 # TODO(tfarina): Only Mac and Linux has the generated config.h for 95 # TODO(tfarina): Only Mac and Linux has the generated config.h for
91 # now. Generate the config.h for Windows too and enable this there 96 # now. Generate the config.h for Windows too and enable this there
92 # as well. 97 # as well.
93 'HAVE_CONFIG_H=1', 98 'HAVE_CONFIG_H=1',
94 ], 99 ],
95 }], 100 }],
96 ], 101 ],
97 }, 102 },
98 ], 103 ],
99 } 104 }
OLDNEW
« no previous file with comments | « third_party/snappy/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698