Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/yasm/BUILD.gn

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/usrsctp/usrsctp.gyp ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/BUILD.gn
diff --git a/third_party/yasm/BUILD.gn b/third_party/yasm/BUILD.gn
index dc6c1166142a00266349d6a4650a2dfba63448dd..fcb779ac82b04ba7c2e85a75b4e869f746b9bddc 100644
--- a/third_party/yasm/BUILD.gn
+++ b/third_party/yasm/BUILD.gn
@@ -150,11 +150,17 @@ if (current_toolchain == host_toolchain) {
config("re2c_warnings") {
# re2c is missing CLOSEVOP from one switch.
- if (is_posix || is_clang) {
- cflags = [ "-Wno-switch" ]
+ if (is_clang) {
+ cflags = [
+ # re2c is missing CLOSEVOP from one switch.
+ "-Wno-switch",
+
+ # re2c contains many static functions in headers (because it's
+ # a C library predating C99.)
+ "-Wno-unused-function",
+ ]
}
}
-
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
":yasm_config",
« no previous file with comments | « third_party/usrsctp/usrsctp.gyp ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698