Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/libxslt/BUILD.gn

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libxml/libxml.gyp ('k') | third_party/libxslt/libxslt.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxslt/BUILD.gn
diff --git a/third_party/libxslt/BUILD.gn b/third_party/libxslt/BUILD.gn
index 24325b03c408de0ef07b9bba06c60f25abd1f60d..6b46db384f56dda1354718f69fa56b5b74767a87 100644
--- a/third_party/libxslt/BUILD.gn
+++ b/third_party/libxslt/BUILD.gn
@@ -59,8 +59,21 @@ static_library("libxslt") {
"win32/config.h",
]
+ config("libxslt_warnings") {
+ if (is_clang) {
+ cflags = [
+ # libxslt stores a char[3] in a `const unsigned char*`.
+ "-Wno-pointer-sign",
+
+ # xsltDefaultRegion and xsltCalibrateTimestamps are only
+ # used with certain preprocessor defines set.
+ "-Wno-unused-function",
+ ]
+ }
+ }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":libxslt_warnings" ]
public_configs = [ ":libxslt_config" ]
cflags = []
@@ -73,10 +86,6 @@ static_library("libxslt") {
include_dirs = [ "mac" ]
}
- if (is_clang) {
- cflags += [ "-Wno-pointer-sign" ]
- }
-
deps = [
"//third_party/libxml",
]
« no previous file with comments | « third_party/libxml/libxml.gyp ('k') | third_party/libxslt/libxslt.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698