Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/snappy/BUILD.gn

Issue 1269293003: Explicitly pass -Wno-unused-function to the targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnnnnnnnnnnn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libxslt/libxslt.gyp ('k') | third_party/snappy/snappy.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("snappy_config") { 5 config("snappy_config") {
6 include_dirs = [ "src" ] 6 include_dirs = [ "src" ]
7 7
8 # These OS-specific generated headers were made by running the configure 8 # These OS-specific generated headers were made by running the configure
9 # script offline. 9 # script offline.
10 if (is_win) { 10 if (is_win) {
11 include_dirs += [ "win32" ] 11 include_dirs += [ "win32" ]
12 } else if (is_mac) { 12 } else if (is_mac) {
13 include_dirs += [ "mac" ] 13 include_dirs += [ "mac" ]
14 } else { 14 } else {
15 include_dirs += [ "linux" ] 15 include_dirs += [ "linux" ]
16 } 16 }
17 } 17 }
18 18
19 static_library("snappy") { 19 static_library("snappy") {
20 sources = [ 20 sources = [
21 "src/snappy-internal.h", 21 "src/snappy-internal.h",
22 "src/snappy-sinksource.cc", 22 "src/snappy-sinksource.cc",
23 "src/snappy-sinksource.h", 23 "src/snappy-sinksource.h",
24 "src/snappy-stubs-internal.cc", 24 "src/snappy-stubs-internal.cc",
25 "src/snappy-stubs-internal.h", 25 "src/snappy-stubs-internal.h",
26 "src/snappy.cc", 26 "src/snappy.cc",
27 "src/snappy.h", 27 "src/snappy.h",
28 ] 28 ]
29 29
30 config("snappy_warnings") {
31 if (is_clang) {
32 # ComputeTable is unused,
33 # https://code.google.com/p/snappy/issues/detail?id=96
34 cflags = [ "-Wno-unused-function" ]
35 }
36 }
30 configs -= [ "//build/config/compiler:chromium_code" ] 37 configs -= [ "//build/config/compiler:chromium_code" ]
31 configs += [ "//build/config/compiler:no_chromium_code" ] 38 configs += [ "//build/config/compiler:no_chromium_code" ]
39 configs += [ ":snappy_warnings" ]
32 public_configs = [ ":snappy_config" ] 40 public_configs = [ ":snappy_config" ]
33 41
34 if (is_win) { 42 if (is_win) {
35 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. 43 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
36 } 44 }
37 45
38 if (is_clang) { 46 if (is_clang) {
39 # snappy-stubs-internal.h unapologetically has: using namespace std 47 # snappy-stubs-internal.h unapologetically has: using namespace std
40 # https://code.google.com/p/snappy/issues/detail?id=70 48 # https://code.google.com/p/snappy/issues/detail?id=70
41 configs -= [ "//build/config/clang:extra_warnings" ] 49 configs -= [ "//build/config/clang:extra_warnings" ]
42 } 50 }
43 } 51 }
OLDNEW
« no previous file with comments | « third_party/libxslt/libxslt.gyp ('k') | third_party/snappy/snappy.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698