Use new GN features in the build.

Use new GN features in the build.

Uses forward_variables_from for some obvious cases not including the Android build, and use the template() function in the component() definition.

Remove uses of component_mode since I want to delete that.

Committed: https://crrev.com/a09029884e02a3c027a485877886cf75969f6b3d
Cr-Commit-Position: refs/heads/master@{#341767}

[brettw, 2015-08-04 16:14:02]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-08-04 16:14:25]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[commit-bot: I haz the power, 2015-08-04 16:14:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265263002/1

[commit-bot: I haz the power, 2015-08-04 16:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 16:22:20]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-08-04 16:38:51]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 16:39:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265263002/20001

[commit-bot: I haz the power, 2015-08-04 17:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 17:05:07]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-08-04 18:19:22]

lgtm. Nice cleanup!

https://codereview.chromium.org/1265263002/diff/20001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1265263002/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:607: # TODO(brettw) Convert this to being a
non-exported variable ('_' prefix) this
clarify that "this" == "component_mode" ?

https://codereview.chromium.org/1265263002/diff/20001/build/config/linux/pkg_...
File build/config/linux/pkg_config.gni (right):

https://codereview.chromium.org/1265263002/diff/20001/build/config/linux/pkg_...
build/config/linux/pkg_config.gni:80: ])
it's a bit goofy that this is five lines instead of one IMO.

[brettw, 2015-08-04 19:10:26]

https://codereview.chromium.org/1265263002/diff/20001/build/config/linux/pkg_...
File build/config/linux/pkg_config.gni (right):

https://codereview.chromium.org/1265263002/diff/20001/build/config/linux/pkg_...
build/config/linux/pkg_config.gni:80: ])
I agree, we should fix the autoformatter at some point (I'm not going to worry
for the moment).

[brettw, 2015-08-04 19:10:31]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-04 19:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1265263002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-04 19:11:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265263002/40001

[commit-bot: I haz the power, 2015-08-04 19:50:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-04 19:53:06]

Patchset 3 (id:??) landed as
https://crrev.com/a09029884e02a3c027a485877886cf75969f6b3d
Cr-Commit-Position: refs/heads/master@{#341767}

[Peng, 2015-08-05 18:45:38]

penghuang@chromium.org changed reviewers:
+ penghuang@chromium.org

[Peng, 2015-08-05 18:45:38]

https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:617: target(component_mode, target_name) {
Build error for mandoline at this line.


ERROR at //build/config/BUILDCONFIG.gn:617:3: Unknown function.
  target(component_mode, target_name) {
  ^-----
See //sync/BUILD.gn:8:1: whence it was called.
component("sync") {
^------------------


The GN args:
use_goma = true
use_aura = true
target_cpu = "x86"
toolkit_views = true
target_os = "android"


PTAL. Thanks.

[brettw, 2015-08-05 20:05:34]

On 2015/08/05 18:45:38, Peng wrote:
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> File build/config/BUILDCONFIG.gn (right):
> 
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> build/config/BUILDCONFIG.gn:617: target(component_mode, target_name) {
> Build error for mandoline at this line.
> 
> 
> ERROR at //build/config/BUILDCONFIG.gn:617:3: Unknown function.
>   target(component_mode, target_name) {
>   ^-----
> See //sync/BUILD.gn:8:1: whence it was called.
> component("sync") {
> ^------------------
> 
> 
> The GN args:
> use_goma = true
> use_aura = true
> target_cpu = "x86"
> toolkit_views = true
> target_os = "android"
> 
> 
> PTAL. Thanks.

That means you have an old build of GN.

[Peng, 2015-08-05 20:08:11]

On 2015/08/05 20:05:34, brettw wrote:
> On 2015/08/05 18:45:38, Peng wrote:
> >
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> > File build/config/BUILDCONFIG.gn (right):
> > 
> >
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> > build/config/BUILDCONFIG.gn:617: target(component_mode, target_name) {
> > Build error for mandoline at this line.
> > 
> > 
> > ERROR at //build/config/BUILDCONFIG.gn:617:3: Unknown function.
> >   target(component_mode, target_name) {
> >   ^-----
> > See //sync/BUILD.gn:8:1: whence it was called.
> > component("sync") {
> > ^------------------
> > 
> > 
> > The GN args:
> > use_goma = true
> > use_aura = true
> > target_cpu = "x86"
> > toolkit_views = true
> > target_os = "android"
> > 
> > 
> > PTAL. Thanks.
> 
> That means you have an old build of GN.

I did rebase and gclient sync. It doesn't fix the issue. How to update the GN?

[brettw, 2015-08-05 20:11:09]

gclient sync should give it to you. Did you do anything to disable hooks?

[Peng, 2015-08-05 20:27:49]

On 2015/08/05 20:08:11, Peng wrote:
> On 2015/08/05 20:05:34, brettw wrote:
> > On 2015/08/05 18:45:38, Peng wrote:
> > >
> >
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> > > File build/config/BUILDCONFIG.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1265263002/diff/40001/build/config/BUILDCONFI...
> > > build/config/BUILDCONFIG.gn:617: target(component_mode, target_name) {
> > > Build error for mandoline at this line.
> > > 
> > > 
> > > ERROR at //build/config/BUILDCONFIG.gn:617:3: Unknown function.
> > >   target(component_mode, target_name) {
> > >   ^-----
> > > See //sync/BUILD.gn:8:1: whence it was called.
> > > component("sync") {
> > > ^------------------
> > > 
> > > 
> > > The GN args:
> > > use_goma = true
> > > use_aura = true
> > > target_cpu = "x86"
> > > toolkit_views = true
> > > target_os = "android"
> > > 
> > > 
> > > PTAL. Thanks.
> > 
> > That means you have an old build of GN.
> 
> I did rebase and gclient sync. It doesn't fix the issue. How to update the GN?

I see. I used gclient sync with --nohooks option (because I use GN, and don't
need update build file from gyp). I resynced my repo without --nohooks. GN
failed on a different place.


[1/1] Regenerating ninja files
FAILED:
/usr/local/google/home/penghuang/sources/chromium/src/buildtools/linux64/gn
--root=/usr/local/google/home/penghuang/sources/chromium/src -q gen
//out/android_x86_Debug/
ERROR at //chrome/browser/ui/BUILD.gn:14:1: Duplicate object file
source_set("ui") {
^-----------------
The target //chrome/browser/ui:ui
generates two object files with the same name:
  obj/chrome/browser/ui/browser_ui/confirm_infobar.o

It could be you accidentally have a file listed twice in the
sources. Or, depending on how your toolchain maps sources to
object files, two source files with the same name in different
directories could map to the same object file.

In the latter case, either rename one of the files or move one of
the sources to a separate source_set to avoid them both being in
the same target.
ninja: error: rebuilding 'build.ninja': subcommand failed

[brettw, 2015-08-05 22:00:34]

You need to run hooks. If you don't want to run GYP, export
GYP_CHROMIUM_NO_ACTION=1

YOu seem to be running a configuration that's not compiled anywhere. I'm
guessing views on Android?
  ./chrome/browser/ui/views/infobars/confirm_infobar.cc
  ./chrome/browser/ui/android/infobars/confirm_infobar.cc
you probably need to decide which of these you mean to be compiling.