Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/protobuf/proto_library.gni

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILDCONFIG.gn ('K') | « third_party/protobuf/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/proto_library.gni
diff --git a/third_party/protobuf/proto_library.gni b/third_party/protobuf/proto_library.gni
index dfa1df283e9ffe0c07ee7dbccfb7dc4f77ccd1e6..c9f100409084dfe40844cada9f708bb6fa39daf8 100644
--- a/third_party/protobuf/proto_library.gni
+++ b/third_party/protobuf/proto_library.gni
@@ -144,21 +144,18 @@ template("proto_library") {
protoc_label,
]
- if (defined(invoker.deps)) {
- deps += invoker.deps
- }
+ forward_variables_from(invoker, [ "deps" ])
}
source_set(target_name) {
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
+ forward_variables_from(invoker,
+ [
+ "visibility",
+ "defines",
+ ])
sources = get_target_outputs(":$action_name")
- if (defined(invoker.defines)) {
- defines = invoker.defines
- }
if (defined(invoker.extra_configs)) {
configs += invoker.extra_configs
}
« build/config/BUILDCONFIG.gn ('K') | « third_party/protobuf/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698