Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/version.gni

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILDCONFIG.gn ('K') | « chrome/test/base/js2gtest.gni ('k') | skia/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/version.gni
diff --git a/chrome/version.gni b/chrome/version.gni
index 45fdcc5c8c8b98d802b0101b3aa13bec6045b44e..b97df390c28767ebd723c0a5325e79f8271cfdb2 100644
--- a/chrome/version.gni
+++ b/chrome/version.gni
@@ -127,9 +127,7 @@ template("process_version") {
if (process_only) {
# When processing only, visibility gets applied to this target.
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
+ forward_variables_from(invoker, [ "visibility" ])
} else {
# When linking the result, only the source set can depend on the action.
visibility = [ ":$source_set_name" ]
@@ -138,9 +136,7 @@ template("process_version") {
if (!process_only) {
source_set(source_set_name) {
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
+ forward_variables_from(invoker, [ "visibility" ])
sources = get_target_outputs(":$action_name")
public_deps = [
":$action_name",
« build/config/BUILDCONFIG.gn ('K') | « chrome/test/base/js2gtest.gni ('k') | skia/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698