Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/test/base/js2gtest.gni

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/js2gtest.gni
diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni
index 35f142f6a63294c7a7947a2a1cf79acb3c32dcb4..4b1dc5f5dbc74722da2bdd36345e2a1b118cb6d2 100644
--- a/chrome/test/base/js2gtest.gni
+++ b/chrome/test/base/js2gtest.gni
@@ -82,13 +82,12 @@ template("js2gtest") {
source_set(source_set_name) {
testonly = true
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
+ forward_variables_from(invoker,
+ [
+ "defines",
+ "visibility",
+ ])
sources = get_target_outputs(":$action_name")
- if (defined(invoker.defines)) {
- defines = invoker.defines
- }
deps = [
":$action_name",

Powered by Google App Engine
This is Rietveld 408576698