Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: build/config/win/manifest.gni

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/win/manifest.gni
diff --git a/build/config/win/manifest.gni b/build/config/win/manifest.gni
index 8da784d936d220285d847c99a2b65a817a4d1c3a..6dc675546f0e44a181de5e26d58a1684d2111d9f 100644
--- a/build/config/win/manifest.gni
+++ b/build/config/win/manifest.gni
@@ -113,9 +113,7 @@ if (is_win) {
# Apply any dependencies from the invoker to this target, since those
# dependencies may have created the input manifest files.
- if (defined(invoker.deps)) {
- deps = invoker.deps
- }
+ forward_variables_from(invoker, [ "deps" ])
}
# Make the .rc file that references the final manifest file. The manifest
@@ -155,9 +153,7 @@ if (is_win) {
# This source set only exists to compile and link the resource file.
source_set(source_set_name) {
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
+ forward_variables_from(invoker, [ "visibility" ])
sources = [
rcfile,
]

Powered by Google App Engine
This is Rietveld 408576698