Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/protobuf/BUILD.gn

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/BUILD.gn
diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn
index 7d42a00dd6a9c36da573ed5c9b31528ec60410aa..2c8d34688e5ae09a2a7d565e08dbb90bf9b22f25 100644
--- a/third_party/protobuf/BUILD.gn
+++ b/third_party/protobuf/BUILD.gn
@@ -19,7 +19,7 @@ config("protobuf_config") {
]
}
-if (component_mode == "shared_library") {
+if (is_component_build) {
config("protobuf_use_dlls") {
defines = [ "PROTOBUF_USE_DLLS" ]
}
@@ -103,7 +103,7 @@ component("protobuf_lite") {
cflags = protobuf_lite_cflags
# Required for component builds. See http://crbug.com/172800.
- if (component_mode == "shared_library") {
+ if (is_component_build) {
public_configs += [ ":protobuf_use_dlls" ]
defines = [ "LIBPROTOBUF_EXPORTS" ]
}

Powered by Google App Engine
This is Rietveld 408576698