Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/BUILD.gn

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILDCONFIG.gn ('K') | « chrome/version.gni ('k') | testing/test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 25515349312909d576cbab1ebf05d913f01e9bef..f629c5acbe9620ef648cc7dbd04a72850241e76d 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -142,7 +142,7 @@ config("skia_config") {
defines += []
- if (component_mode == "shared_library") {
+ if (is_component_build) {
defines += [
"SKIA_DLL",
"GR_GL_IGNORE_ES3_MSAA=0",
@@ -196,7 +196,7 @@ config("skia_library_config") {
defines = []
- if (component_mode == "shared_library") {
+ if (is_component_build) {
defines += [ "SKIA_IMPLEMENTATION=1" ]
}
« build/config/BUILDCONFIG.gn ('K') | « chrome/version.gni ('k') | testing/test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698