Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261433009: Refugee from Dead Machine 11: Add SkCanvas::drawLitAtlas call

Created:
5 years, 4 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkCanvas::drawLitAtlas call There are several portions to this CL: add a separate light object that can be refed add support for multiple lights upgrade the SkLightingShader to handle rotated geometry actually add the new drawLitAtlas call add a new Sample slide that demonstrates the lit atlas AFAICT the only item remaining unlanded in this CL is the drawLitAtlas and onDrawLitAtlas methods.

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : updater #

Patch Set 5 : update #

Patch Set 6 : update #

Patch Set 7 : update #

Patch Set 8 : update #

Patch Set 9 : update #

Patch Set 10 : cleanup #

Patch Set 11 : more clean up #

Patch Set 12 : update #

Patch Set 13 : update #

Patch Set 14 : update to ToT #

Patch Set 15 : update to ToT #

Patch Set 16 : update #

Patch Set 17 : update to ToT #

Patch Set 18 : update #

Patch Set 19 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1265 lines, -992 lines) Patch
M gm/lightingshader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +13 lines, -7 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -4 lines 0 comments Download
M gyp/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +6 lines, -1 line 0 comments Download
M gyp/effects.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +0 lines, -4 lines 0 comments Download
M gyp/libjpeg-turbo.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +17 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -0 lines 0 comments Download
A include/core/SkLight.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +56 lines, -0 lines 0 comments Download
A + include/core/SkPoint3.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +16 lines, -0 lines 0 comments Download
D include/effects/SkPoint3.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -108 lines 0 comments Download
M include/private/SkRecords.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +29 lines, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -0 lines 0 comments Download
M include/utils/SkMatrix44.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleLighting.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +26 lines, -14 lines 0 comments Download
A samplecode/SampleLitAtlas.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +430 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +38 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +64 lines, -0 lines 0 comments Download
A + src/core/SkLightingShader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +48 lines, -7 lines 0 comments Download
A + src/core/SkLightingShader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 21 chunks +316 lines, -116 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +46 lines, -0 lines 0 comments Download
A + src/core/SkPoint3.cpp View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +18 lines, -0 lines 0 comments Download
M src/effects/SkLightingShader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -59 lines 0 comments Download
M src/effects/SkLightingShader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -587 lines 0 comments Download
D src/effects/SkPoint3.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -80 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +35 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +56 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
robertphillips
4 years, 6 months ago (2016-06-03 15:47:12 UTC) #1 
Description was changed from

==========
Add SkCanvas::drawLitAtlas call

There are several portions to this CL:

add a separate light object that can be refed
add support for multiple lights
upgrade the SkLightingShader to handle rotated geometry
actually add the new drawLitAtlas call
add a new Sample slide that demonstrates the lit atlas
==========

to

==========
Add SkCanvas::drawLitAtlas call

There are several portions to this CL:

add a separate light object that can be refed
add support for multiple lights
upgrade the SkLightingShader to handle rotated geometry
actually add the new drawLitAtlas call
add a new Sample slide that demonstrates the lit atlas

AFAICT the only item remaining unlanded in this CL is the drawLitAtlas and
onDrawLitAtlas methods.
==========

Powered by Google App Engine
This is Rietveld 408576698