Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1247723004: Remove 'blink::WebSerializedOrigin' (5/7) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (5/7) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): https://codereview.chromium.org/1244563002 Patch 2 (Blink): https://codereview.chromium.org/1240083002 Patch 3 (Blink): https://codereview.chromium.org/1244703002 Patch 4 (Chromium): https://codereview.chromium.org/1229783005 Patch 5 (Chromium): This patch. Patch 6 (Blink): https://codereview.chromium.org/1231643010 Patch 7 (Chromium): https://codereview.chromium.org/1246943002 BUG=508896 R=jochen@chromium.org Committed: https://crrev.com/9ece9f35bef8fc3a372fc484d14c9bcb7854cf9c Cr-Commit-Position: refs/heads/master@{#339632}

Patch Set 1 #

Patch Set 2 : take2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/html_viewer/web_notification_manager_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Mike West
*sobs* WDYT?
5 years, 5 months ago (2015-07-21 08:46:11 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-21 08:46:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247723004/1
5 years, 5 months ago (2015-07-21 08:47:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/111822)
5 years, 5 months ago (2015-07-21 08:57:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247723004/20001
5 years, 5 months ago (2015-07-21 09:05:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 09:17:25 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 09:18:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ece9f35bef8fc3a372fc484d14c9bcb7854cf9c
Cr-Commit-Position: refs/heads/master@{#339632}

Powered by Google App Engine
This is Rietveld 408576698