Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1246943002: Remove 'blink::WebSerializedOrigin' (7/7) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ugh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (7/7) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): https://codereview.chromium.org/1244563002 Patch 2 (Blink): https://codereview.chromium.org/1240083002 Patch 3 (Blink): https://codereview.chromium.org/1244703002 Patch 4 (Chromium): https://codereview.chromium.org/1229783005 Patch 5 (Chromium): https://codereview.chromium.org/1247723004/ Patch 6 (Blink): https://codereview.chromium.org/1231643010 Patch 7 (Chromium): This patch. BUG=508896 R=jochen@chromium.org Committed: https://crrev.com/b5dc9fd49be7cc5f410cdaf94e131862766ee372 Cr-Commit-Position: refs/heads/master@{#339648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M components/html_viewer/web_notification_manager_impl.h View 2 chunks +0 lines, -15 lines 0 comments Download
M components/html_viewer/web_notification_manager_impl.cc View 4 chunks +0 lines, -32 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Mike West
More sobs. (Patch 5 now just forward declares the thing I'm removing. This patch kills ...
5 years, 5 months ago (2015-07-21 09:08:48 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-21 09:14:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246943002/1
5 years, 5 months ago (2015-07-21 14:03:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 14:24:12 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 14:25:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5dc9fd49be7cc5f410cdaf94e131862766ee372
Cr-Commit-Position: refs/heads/master@{#339648}

Powered by Google App Engine
This is Rietveld 408576698