Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1244563002: Remove 'blink::WebSerializedOrigin' (1/4) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (1/4) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): This patch. Patch 1 (Blink): https://codereview.chromium.org/1240083002 Patch 2 (Chromium): https://codereview.chromium.org/1229783005 Patch 3 (Blink): https://codereview.chromium.org/1231643010 BUG=508896 R=jochen@chromium.org Committed: https://crrev.com/24235257364fcf3ad1597022364682f174d92791 Cr-Commit-Position: refs/heads/master@{#339235}

Patch Set 1 #

Patch Set 2 : forward #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M components/html_viewer/web_notification_manager_impl.h View 1 3 chunks +18 lines, -0 lines 0 comments Download
M components/html_viewer/web_notification_manager_impl.cc View 4 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Mind taking a look at this, Jochen? The GN build has the '-Woverloaded-virtual' flag on ...
5 years, 5 months ago (2015-07-17 08:44:29 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 09:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244563002/20001
5 years, 5 months ago (2015-07-17 09:44:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 09:55:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 09:56:48 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24235257364fcf3ad1597022364682f174d92791
Cr-Commit-Position: refs/heads/master@{#339235}

Powered by Google App Engine
This is Rietveld 408576698