Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1240083002: Remove 'blink::WebSerializedOrigin' (2/4) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, peter+watch_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (2/4) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): https://codereview.chromium.org/1244563002 Patch 2 (Blink): This patch. Patch 3 (Chromium): https://codereview.chromium.org/1229783005 Patch 4 (Blink): https://codereview.chromium.org/1231643010 ------------------------------------------------------------------------ This is a re-land of https://codereview.chromium.org/1232563003, which was reverted due to compilation errors that the CQ didn't catch. ------------------------------------------------------------------------ BUG=508896 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M Source/modules/notifications/Notification.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/exported/WebSerializedOrigin.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebSerializedOrigin.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/WebSocketHandle.h View 2 chunks +8 lines, -2 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 4 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
This is exactly the same as the patch you LGTM'd a few days ago, but ...
5 years, 5 months ago (2015-07-17 08:45:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240083002/1
5 years, 5 months ago (2015-07-17 08:45:31 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-17 09:26:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240083002/1
5 years, 5 months ago (2015-07-17 09:57:39 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 11:06:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199097

Powered by Google App Engine
This is Rietveld 408576698