Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1229783005: Remove 'blink::WebSerializedOrigin' (4/5) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (4/5) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): https://codereview.chromium.org/1244563002 Patch 2 (Blink): https://codereview.chromium.org/1240083002 Patch 3 (Blink): https://codereview.chromium.org/1244703002 Patch 4 (Chromium): This patch. Patch 5 (Blink): https://codereview.chromium.org/1231643010 BUG=508896 R=jochen@chromium.org Committed: https://crrev.com/808535c6118fcbecdf8caf6309ab5a7b99d02bd3 Cr-Commit-Position: refs/heads/master@{#339497}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rebase-error #

Patch Set 4 : fix html_viewer #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M components/html_viewer/web_notification_manager_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_socket_handle_impl.h View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/notifications/notification_manager.h View 4 chunks +7 lines, -8 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 8 chunks +27 lines, -23 lines 0 comments Download
M content/child/notifications/pending_notifications_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/notifications/pending_notifications_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/websocket_bridge.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/websocket_bridge.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
Mike West
Jochen, Peter, WDYT?
5 years, 5 months ago (2015-07-10 14:02:13 UTC) #2
Peter Beverloo
lgtm https://codereview.chromium.org/1229783005/diff/1/content/child/notifications/notification_manager.cc File content/child/notifications/notification_manager.cc (right): https://codereview.chromium.org/1229783005/diff/1/content/child/notifications/notification_manager.cc#newcode190 content/child/notifications/notification_manager.cc:190: // TODO(mkwst): This is potentially doing the wrong ...
5 years, 5 months ago (2015-07-10 14:19:17 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-13 08:53:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/1
5 years, 5 months ago (2015-07-17 13:30:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/74697) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-17 13:31:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/1
5 years, 5 months ago (2015-07-17 13:40:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/97027) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-17 13:42:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/20001
5 years, 5 months ago (2015-07-17 13:56:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/92862) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-17 14:06:46 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/20001
5 years, 5 months ago (2015-07-19 14:05:30 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/75026)
5 years, 5 months ago (2015-07-19 14:15:14 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/40001
5 years, 5 months ago (2015-07-19 14:39:26 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/109945)
5 years, 5 months ago (2015-07-19 14:52:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229783005/80001
5 years, 5 months ago (2015-07-20 18:53:51 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-20 20:11:51 UTC) #29
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 20:12:38 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/808535c6118fcbecdf8caf6309ab5a7b99d02bd3
Cr-Commit-Position: refs/heads/master@{#339497}

Powered by Google App Engine
This is Rietveld 408576698