Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 1244703002: Remove 'blink::WebSerializedOrigin' (3/4) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, peter+watch_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (3/5) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Chromium): https://codereview.chromium.org/1244563002 Patch 2 (Blink): https://codereview.chromium.org/1240083002 Patch 3 (Blink): This patch (oops). Patch 4 (Chromium): https://codereview.chromium.org/1229783005 Patch 5 (Blink): https://codereview.chromium.org/1231643010 BUG=508896 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199166

Patch Set 1 #

Patch Set 2 : empty #

Patch Set 3 : yay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/modules/notifications/Notification.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Mike West
Hey Jochen! I need to move some of the bits of patch #5 (https://codereview.chromium.org/1231643010) that ...
5 years, 5 months ago (2015-07-20 08:05:30 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-20 08:10:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244703002/1
5 years, 5 months ago (2015-07-20 08:31:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/63332)
5 years, 5 months ago (2015-07-20 08:59:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244703002/20001
5 years, 5 months ago (2015-07-20 10:25:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244703002/40001
5 years, 5 months ago (2015-07-20 11:34:08 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 13:10:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199166

Powered by Google App Engine
This is Rietveld 408576698