Remove 'blink::WebSerializedOrigin' (6/6)

Remove 'blink::WebSerializedOrigin' (6/6)

As part of the plan to rationalize Origins across Blink and its embedder,
we're dropping 'blink::WebSerializedOrigin' in favor of
'blink::WebSecurityOrigin' (which can serialize itself just fine).

Patch 1 (Chromium): https://codereview.chromium.org/1244563002
Patch 2 (Blink): https://codereview.chromium.org/1240083002
Patch 3 (Blink): https://codereview.chromium.org/1244703002
Patch 4 (Chromium): https://codereview.chromium.org/1229783005
Patch 5 (Chromium): https://codereview.chromium.org/1247723004
Patch 6 (Blin~k): This patch.

BUG=508896
R=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199216

[Mike West, 2015-07-10 14:02:31]

mkwst@chromium.org changed reviewers:
+ peter@chromium.org

[Mike West, 2015-07-10 14:02:32]

Jochen, Peter, WDYT?

https://codereview.chromium.org/1231643010/diff/1/Source/platform/exported/We...
File Source/platform/exported/WebSecurityOrigin.cpp (right):

https://codereview.chromium.org/1231643010/diff/1/Source/platform/exported/We...
Source/platform/exported/WebSecurityOrigin.cpp:139: :
m_private(static_cast<WebSecurityOriginPrivate*>(origin->isolatedCopy().leakRef()))
This feels a little ugly. If you have suggestions, I'd love to hear them.

[Peter Beverloo, 2015-07-10 14:27:03]

lgtm

https://codereview.chromium.org/1231643010/diff/1/Source/platform/exported/We...
File Source/platform/exported/WebSecurityOrigin.cpp (right):

https://codereview.chromium.org/1231643010/diff/1/Source/platform/exported/We...
Source/platform/exported/WebSecurityOrigin.cpp:139: :
m_private(static_cast<WebSecurityOriginPrivate*>(origin->isolatedCopy().leakRef()))
On 2015/07/10 14:02:31, Mike West wrote:
> This feels a little ugly. If you have suggestions, I'd love to hear them.

The obvious option would be for ExecutionContext::securityOrigin() to return a
RefPtr, which matches the underlying type. It'll be a non-trivial clean-up
though.

Since we can't rely on where SecurityOrigin* comes from (it could be on stack),
this seems fine.

[jochen (gone - plz use gerrit), 2015-07-13 08:54:33]

lgtm

[Mike West, 2015-07-21 08:12:57]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-07-21 08:12:58]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1231643010/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-07-21 08:13:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231643010/20001

[commit-bot: I haz the power, 2015-07-21 09:06:45]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199216

[Mike West, 2015-07-21 09:09:42]

On 2015/07/21 at 09:06:45, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199216

I have no idea how the CQ landed this, since it's failing to compile under
Chromium. The deps roller is going to be blocked until
https://codereview.chromium.org/1247723004/ lands, but letting that go through
is faster than reverting this and then landing both again, so I'll just leave
it. :/