Pass scroll bar placement as an enum instead of std::string

Pass scroll bar placement as an enum instead of std::string

I was asked to pass the scroll bar placement over IPC as an enum instead of an std::string, so the Blink side change now expects the enum directly, and exposes the enum in a header to chrome.

BUG=392141
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199383

[Greg K, 2015-07-21 20:39:19]

Patchset #1 (id:1) has been deleted

[Greg K, 2015-07-21 22:11:22]

kerrnel@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-07-22 09:52:49]

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
File Source/platform/scroll/ScrollbarThemeMacCommon.h (left):

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
Source/platform/scroll/ScrollbarThemeMacCommon.h:41: 
nit. don't delete that line

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
File Source/platform/scroll/ScrollbarThemeMacCommon.h (right):

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
Source/platform/scroll/ScrollbarThemeMacCommon.h:43: void
preferencesChanged(float initialButtonDelay, float autoscrollButtonDelay,
NSScrollerStyle preferredScrollerStyle, bool redraw, bool
scrollAnimationEnabled, ScrollbarButtonsPlacement buttonPlacement);
same here (and everywhere), drop buttonPlacement

https://codereview.chromium.org/1245323002/diff/20001/public/platform/mac/Mac...
File public/platform/mac/MacScrollTypes.h (right):

https://codereview.chromium.org/1245323002/diff/20001/public/platform/mac/Mac...
public/platform/mac/MacScrollTypes.h:11: ScrollbarButtonsNone,
enum values should start with the name of the enum (i.e.
ScrollbarButtonsPlacementNone). Or use an enum class

https://codereview.chromium.org/1245323002/diff/20001/public/web/mac/WebScrol...
File public/web/mac/WebScrollbarTheme.h (right):

https://codereview.chromium.org/1245323002/diff/20001/public/web/mac/WebScrol...
public/web/mac/WebScrollbarTheme.h:60: bool scrollAnimationEnabled,
ScrollbarButtonsPlacement buttonPlacement);
now the name "buttonPlacement" doesn't add any value, just omit it.

[Greg K, 2015-07-22 19:41:55]

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
File Source/platform/scroll/ScrollbarThemeMacCommon.h (left):

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
Source/platform/scroll/ScrollbarThemeMacCommon.h:41: 
On 2015/07/22 09:52:49, jochen wrote:
> nit. don't delete that line

Done.

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
File Source/platform/scroll/ScrollbarThemeMacCommon.h (right):

https://codereview.chromium.org/1245323002/diff/20001/Source/platform/scroll/...
Source/platform/scroll/ScrollbarThemeMacCommon.h:43: void
preferencesChanged(float initialButtonDelay, float autoscrollButtonDelay,
NSScrollerStyle preferredScrollerStyle, bool redraw, bool
scrollAnimationEnabled, ScrollbarButtonsPlacement buttonPlacement);
On 2015/07/22 09:52:49, jochen wrote:
> same here (and everywhere), drop buttonPlacement

Done.

https://codereview.chromium.org/1245323002/diff/20001/public/platform/mac/Mac...
File public/platform/mac/MacScrollTypes.h (right):

https://codereview.chromium.org/1245323002/diff/20001/public/platform/mac/Mac...
public/platform/mac/MacScrollTypes.h:11: ScrollbarButtonsNone,
On 2015/07/22 09:52:49, jochen wrote:
> enum values should start with the name of the enum (i.e.
> ScrollbarButtonsPlacementNone). Or use an enum class

Done.

https://codereview.chromium.org/1245323002/diff/20001/public/web/mac/WebScrol...
File public/web/mac/WebScrollbarTheme.h (right):

https://codereview.chromium.org/1245323002/diff/20001/public/web/mac/WebScrol...
public/web/mac/WebScrollbarTheme.h:60: bool scrollAnimationEnabled,
ScrollbarButtonsPlacement buttonPlacement);
On 2015/07/22 09:52:49, jochen wrote:
> now the name "buttonPlacement" doesn't add any value, just omit it.

Done.

[jochen (gone - plz use gerrit), 2015-07-23 09:20:39]

lgtm

[Greg K, 2015-07-23 16:38:11]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2015-07-23 16:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1245323002/40001

[commit-bot: I haz the power, 2015-07-23 17:54:37]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199383