public/platform/mac/MacScrollTypes.h - Issue 1245323002: Pass scroll bar placement as an enum instead of std::string

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/platform/mac/MacScrollTypes.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix the headers to pass depchecks Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MacScrollTypes_h

	6 #define MacScrollTypes_h

	7

	8 namespace blink {

	9

	10 enum ScrollbarButtonsPlacement {

	11 ScrollbarButtonsNone,
	jochen (gone - plz use gerrit) 2015/07/22 09:52:49 enum values should start with the name of the enum enum values should start with the name of the enum (i.e. ScrollbarButtonsPlacementNone). Or use an enum class Greg K 2015/07/22 19:41:55 Done. Show quoted text On 2015/07/22 09:52:49, jochen wrote: > enum values should start with the name of the enum (i.e. > ScrollbarButtonsPlacementNone). Or use an enum class Done.
	12 ScrollbarButtonsSingle,

	13 ScrollbarButtonsDoubleStart,

	14 ScrollbarButtonsDoubleEnd,

	15 ScrollbarButtonsDoubleBoth,

	16 ScrollbarButtonsPlacementLast = ScrollbarButtonsDoubleBoth

	17 };

	18

	19 }

	20

	21 #endif // MacScrollTypes_h

OLD	NEW

« Source/platform/scroll/ScrollbarThemeMacCommon.h ('K') | « Source/web/mac/WebScrollbarTheme.mm ('k') | public/web/mac/WebScrollbarTheme.h » ('j') | public/web/mac/WebScrollbarTheme.h » ('J')