Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: Source/core/layout/LayoutScrollbar.cpp

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updates per code review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/SelectorChecker.cpp ('k') | Source/platform/scroll/ScrollTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutScrollbar.cpp
diff --git a/Source/core/layout/LayoutScrollbar.cpp b/Source/core/layout/LayoutScrollbar.cpp
index 819c2754d66c3cc248b4753a622d3832eb87ca01..1829b789c01c9dcd836012414a8c8f9d67b8d81c 100644
--- a/Source/core/layout/LayoutScrollbar.cpp
+++ b/Source/core/layout/LayoutScrollbar.cpp
@@ -237,18 +237,18 @@ void LayoutScrollbar::updateScrollbarPart(ScrollbarPart partType, bool destroy)
ScrollbarButtonsPlacement buttonsPlacement = theme()->buttonsPlacement();
switch (partType) {
case BackButtonStartPart:
- needLayoutObject = (buttonsPlacement == ScrollbarButtonsSingle || buttonsPlacement == ScrollbarButtonsDoubleStart
- || buttonsPlacement == ScrollbarButtonsDoubleBoth);
+ needLayoutObject = (buttonsPlacement == ScrollbarButtonsPlacementSingle || buttonsPlacement == ScrollbarButtonsPlacementDoubleStart
+ || buttonsPlacement == ScrollbarButtonsPlacementDoubleBoth);
break;
case ForwardButtonStartPart:
- needLayoutObject = (buttonsPlacement == ScrollbarButtonsDoubleStart || buttonsPlacement == ScrollbarButtonsDoubleBoth);
+ needLayoutObject = (buttonsPlacement == ScrollbarButtonsPlacementDoubleStart || buttonsPlacement == ScrollbarButtonsPlacementDoubleBoth);
break;
case BackButtonEndPart:
- needLayoutObject = (buttonsPlacement == ScrollbarButtonsDoubleEnd || buttonsPlacement == ScrollbarButtonsDoubleBoth);
+ needLayoutObject = (buttonsPlacement == ScrollbarButtonsPlacementDoubleEnd || buttonsPlacement == ScrollbarButtonsPlacementDoubleBoth);
break;
case ForwardButtonEndPart:
- needLayoutObject = (buttonsPlacement == ScrollbarButtonsSingle || buttonsPlacement == ScrollbarButtonsDoubleEnd
- || buttonsPlacement == ScrollbarButtonsDoubleBoth);
+ needLayoutObject = (buttonsPlacement == ScrollbarButtonsPlacementSingle || buttonsPlacement == ScrollbarButtonsPlacementDoubleEnd
+ || buttonsPlacement == ScrollbarButtonsPlacementDoubleBoth);
break;
default:
break;
« no previous file with comments | « Source/core/css/SelectorChecker.cpp ('k') | Source/platform/scroll/ScrollTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698