Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: Source/platform/scroll/ScrollbarThemeMacCommon.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updates per code review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/scroll/ScrollbarTheme.h ('k') | Source/platform/scroll/ScrollbarThemeMacCommon.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/scroll/ScrollbarThemeMacCommon.h
diff --git a/Source/platform/scroll/ScrollbarThemeMacCommon.h b/Source/platform/scroll/ScrollbarThemeMacCommon.h
index c3e7fde10d5d82dd941b9803a57b43aa0fc7d26b..7d9cedce37b7bf01ca763e98bb0e613df82c1db9 100644
--- a/Source/platform/scroll/ScrollbarThemeMacCommon.h
+++ b/Source/platform/scroll/ScrollbarThemeMacCommon.h
@@ -41,7 +41,7 @@ public:
void registerScrollbar(ScrollbarThemeClient*) override;
void unregisterScrollbar(ScrollbarThemeClient*) override;
- void preferencesChanged(float initialButtonDelay, float autoscrollButtonDelay, NSScrollerStyle preferredScrollerStyle, bool redraw, bool scrollAnimationEnabled, const std::string& buttonPlacement);
+ void preferencesChanged(float initialButtonDelay, float autoscrollButtonDelay, NSScrollerStyle preferredScrollerStyle, bool redraw, bool scrollAnimationEnabled, ScrollbarButtonsPlacement);
bool supportsControlTints() const override { return true; }
@@ -62,7 +62,7 @@ protected:
bool shouldDragDocumentInsteadOfThumb(ScrollbarThemeClient*, const PlatformMouseEvent&) override;
int scrollbarPartToHIPressedState(ScrollbarPart);
- virtual void updateButtonPlacement(const std::string& buttonPlacement) {}
+ virtual void updateButtonPlacement(ScrollbarButtonsPlacement) {}
void paintGivenTickmarks(SkCanvas*, ScrollbarThemeClient*, const IntRect&, const Vector<IntRect>&);
« no previous file with comments | « Source/platform/scroll/ScrollbarTheme.h ('k') | Source/platform/scroll/ScrollbarThemeMacCommon.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698