Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h - Issue 1245323002: Pass scroll bar placement as an enum instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updates per code review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

diff --git a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

index 27a260bd6065d0e5455d3c82f99e8474d2d10205..88e6ef8b0f3a3952285b0d150995aeaa60360b09 100644

--- a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

+++ b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

@@ -48,7 +48,7 @@ protected:

IntRect backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

IntRect forwardButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

- void updateButtonPlacement(const std::string& buttonPlacement) override;

+ void updateButtonPlacement(ScrollbarButtonsPlacement) override;

bool hasButtons(ScrollbarThemeClient*) override;

bool hasThumb(ScrollbarThemeClient*) override;

« no previous file with comments | « Source/platform/scroll/ScrollbarThemeMacCommon.mm ('k') | Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm » ('j') | no next file with comments »