Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Side by Side Diff: Source/platform/scroll/ScrollbarThemeMacCommon.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updates per code review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 namespace blink { 34 namespace blink {
35 35
36 class Pattern; 36 class Pattern;
37 37
38 class PLATFORM_EXPORT ScrollbarThemeMacCommon : public ScrollbarTheme { 38 class PLATFORM_EXPORT ScrollbarThemeMacCommon : public ScrollbarTheme {
39 public: 39 public:
40 ~ScrollbarThemeMacCommon() override; 40 ~ScrollbarThemeMacCommon() override;
41 41
42 void registerScrollbar(ScrollbarThemeClient*) override; 42 void registerScrollbar(ScrollbarThemeClient*) override;
43 void unregisterScrollbar(ScrollbarThemeClient*) override; 43 void unregisterScrollbar(ScrollbarThemeClient*) override;
44 void preferencesChanged(float initialButtonDelay, float autoscrollButtonDela y, NSScrollerStyle preferredScrollerStyle, bool redraw, bool scrollAnimationEnab led, const std::string& buttonPlacement); 44 void preferencesChanged(float initialButtonDelay, float autoscrollButtonDela y, NSScrollerStyle preferredScrollerStyle, bool redraw, bool scrollAnimationEnab led, ScrollbarButtonsPlacement);
45 45
46 bool supportsControlTints() const override { return true; } 46 bool supportsControlTints() const override { return true; }
47 47
48 double initialAutoscrollTimerDelay() override; 48 double initialAutoscrollTimerDelay() override;
49 double autoscrollTimerDelay() override; 49 double autoscrollTimerDelay() override;
50 50
51 void paintTickmarks(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) override; 51 void paintTickmarks(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) override;
52 52
53 static NSScrollerStyle recommendedScrollerStyle(); 53 static NSScrollerStyle recommendedScrollerStyle();
54 54
55 static bool isOverlayAPIAvailable(); 55 static bool isOverlayAPIAvailable();
56 56
57 static bool scrollAnimationEnabledForSystem(); 57 static bool scrollAnimationEnabledForSystem();
58 58
59 protected: 59 protected:
60 int maxOverlapBetweenPages() override { return 40; } 60 int maxOverlapBetweenPages() override { return 40; }
61 61
62 bool shouldDragDocumentInsteadOfThumb(ScrollbarThemeClient*, const PlatformM ouseEvent&) override; 62 bool shouldDragDocumentInsteadOfThumb(ScrollbarThemeClient*, const PlatformM ouseEvent&) override;
63 int scrollbarPartToHIPressedState(ScrollbarPart); 63 int scrollbarPartToHIPressedState(ScrollbarPart);
64 64
65 virtual void updateButtonPlacement(const std::string& buttonPlacement) {} 65 virtual void updateButtonPlacement(ScrollbarButtonsPlacement) {}
66 66
67 void paintGivenTickmarks(SkCanvas*, ScrollbarThemeClient*, const IntRect&, c onst Vector<IntRect>&); 67 void paintGivenTickmarks(SkCanvas*, ScrollbarThemeClient*, const IntRect&, c onst Vector<IntRect>&);
68 68
69 RefPtr<Pattern> m_overhangPattern; 69 RefPtr<Pattern> m_overhangPattern;
70 }; 70 };
71 71
72 } 72 }
73 73
74 #endif // ScrollbarThemeMacCommon_h 74 #endif // ScrollbarThemeMacCommon_h
OLDNEW
« no previous file with comments | « Source/platform/scroll/ScrollbarTheme.h ('k') | Source/platform/scroll/ScrollbarThemeMacCommon.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698