public/web/mac/WebScrollbarTheme.h - Issue 1245323002: Pass scroll bar placement as an enum instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/mac/WebScrollbarTheme.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updates per code review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/mac/WebScrollbarTheme.h

diff --git a/public/web/mac/WebScrollbarTheme.h b/public/web/mac/WebScrollbarTheme.h

index 4ba409d6c4f709b23088c4287a2feb9bfc88e3fd..11e8aac144afc3c923f0de89513e2ab44331c9c4 100644

--- a/public/web/mac/WebScrollbarTheme.h

+++ b/public/web/mac/WebScrollbarTheme.h

@@ -32,8 +32,7 @@

#define WebScrollbarTheme_h

#include "public/platform/WebCommon.h"

-#include <string>

+#include "public/platform/mac/MacScrollTypes.h"

namespace blink {

@@ -58,7 +57,7 @@ public:

BLINK_EXPORT static void updateScrollbarsWithNSDefaults(

float initialButtonDelay, float autoscrollButtonDelay,

ScrollerStyle preferredScrollerStyle, bool redraw,

- bool scrollAnimationEnabled, const std::string& buttonPlacement);

+ bool scrollAnimationEnabled, ScrollbarButtonsPlacement);

};

} // namespace blink

« no previous file with comments | « public/platform/mac/MacScrollTypes.h ('k') | no next file » | no next file with comments »