Create classes_util API, change discover to return a list instead of a dict.

Create classes_util API, change discover to return a list instead of a dict.

BUG=498968
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
Cr-Commit-Position: refs/heads/master@{#341129}

[aiolos (Not reviewing), 2015-07-21 20:39:35]

Patchset #2 (id:20001) has been deleted

[aiolos (Not reviewing), 2015-07-21 21:20:27]

aiolos@chromium.org changed reviewers:
+ dtu@chromium.org

[aiolos (Not reviewing), 2015-07-21 21:22:14]

aiolos@chromium.org changed reviewers:
+ bengr@chromium.org

[dtu, 2015-07-21 21:50:04]

lgtm

[aiolos (Not reviewing), 2015-07-22 00:29:50]

Note that the only failing test on the linux bot is failing without the patch as
well. I'll retry the bot in a little while.

[aiolos (Not reviewing), 2015-07-24 18:08:23]

ping

[dtu, 2015-07-24 19:36:00]

On 2015/07/24 18:08:23, aiolos wrote:
> ping

Still lgtm

[dtu, 2015-07-24 19:36:22]

On 2015/07/24 19:36:00, dtu wrote:
> On 2015/07/24 18:08:23, aiolos wrote:
> > ping
> 
> Still lgtm

Oh whoops sorry you're waiting for chrome_proxy

[bengr, 2015-07-24 22:36:26]

https://codereview.chromium.org/1244223002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py
(right):

https://codereview.chromium.org/1244223002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py:19: for
cls in calsses_util.DiscoverClasses(start_dir, top_level_dir, base_class):
spelling?

[aiolos (Not reviewing), 2015-07-29 19:29:22]

Still working on getting the tests that Ben asked me to run working, even on a
clean checkout.

https://codereview.chromium.org/1244223002/diff/40001/tools/chrome_proxy/inte...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py
(right):

https://codereview.chromium.org/1244223002/diff/40001/tools/chrome_proxy/inte...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py:19: for
cls in calsses_util.DiscoverClasses(start_dir, top_level_dir, base_class):
On 2015/07/24 22:36:26, bengr wrote:
> spelling?

Done.

[aiolos (Not reviewing), 2015-07-29 21:48:51]

Patchset #5 (id:100001) has been deleted

[aiolos (Not reviewing), 2015-07-29 22:40:34]

From talking to bustamante@ offine, it is fine to ignore the failures on
chrome_proxy_benchmark.client_config.synthetic since it is failing for him as
well.

Link to doc showing output of passing tests with this CL (on either tot or
stable chrome as needed) for all of the other tests on the chrome_proxy
waterfall (google account only viewable):
https://docs.google.com/a/google.com/document/d/1S9ZK2_5tRMV8Jg7dpphPEsHOr7AP...

[bengr, 2015-07-29 22:42:53]

chrome_proxy lgtm

[aiolos (Not reviewing), 2015-07-29 22:43:27]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2015-07-29 22:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/1244223002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-07-29 22:44:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1244223002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1244223002/120001

[commit-bot: I haz the power, 2015-07-30 00:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 00:45:38]

Try jobs failed on following builders:
  win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[aiolos (Not reviewing), 2015-07-30 16:19:58]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2015-07-30 16:20:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1244223002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1244223002/120001

[commit-bot: I haz the power, 2015-07-30 16:25:50]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-07-30 16:26:32]

Patchset 5 (id:??) landed as
https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
Cr-Commit-Position: refs/heads/master@{#341129}

[Avi (use Gerrit), 2015-07-30 23:04:46]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/1263063003/ by avi@chromium.org.

The reason for reverting is: This appears to break the XP telemetry tests.
Details on the bug..