tools/telemetry/telemetry/core/platform.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/discover_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform.py

diff --git a/tools/telemetry/telemetry/core/platform.py b/tools/telemetry/telemetry/core/platform.py

index a9566a945439a463ea277ae54c37cbe0c6a60087..2b2ba3e1be673bbb6be19445a8ba5bf94dd8c3ed 100644

--- a/tools/telemetry/telemetry/core/platform.py

+++ b/tools/telemetry/telemetry/core/platform.py

@@ -4,11 +4,11 @@

import logging as real_logging

import os

-from telemetry.core import discover

from telemetry.core import network_controller

from telemetry.core import tracing_controller

from telemetry.core import util

from telemetry.internal.platform import platform_backend as platform_backend_module

+from telemetry.util import classes_util

_host_platform = None

@@ -39,9 +39,9 @@ def GetHostPlatform():

def _IterAllPlatformBackendClasses():

platform_dir = os.path.dirname(

os.path.realpath(platform_backend_module.__file__))

- return discover.DiscoverClasses(

+ return classes_util.DiscoverClasses(

platform_dir, util.GetTelemetryDir(),

- platform_backend_module.PlatformBackend).itervalues()

+ platform_backend_module.PlatformBackend)

def GetPlatformForDevice(device, finder_options, logging=real_logging):