tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform.py ('k') | tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py

diff --git a/tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py b/tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py

index 33c31e56bd826d4a8c90ed84c1557cc7f5bf195a..58afd7577f72ae079fd176d438abe05718423d59 100644

--- a/tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py

+++ b/tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py

@@ -4,16 +4,15 @@

import os

-from telemetry.core import discover

from telemetry.internal.platform import profiler

from telemetry.core import util

+from telemetry.util import classes_util

def _DiscoverProfilers():

profiler_dir = os.path.dirname(__file__)

- return discover.DiscoverClasses(profiler_dir, util.GetTelemetryDir(),

- profiler.Profiler,

- index_by_class_name=True).values()

+ return classes_util.DiscoverClasses(

+ profiler_dir, util.GetTelemetryDir(), profiler.Profiler)

def FindProfiler(name):