tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py ('k') | tools/telemetry/telemetry/internal/util/find_dependencies.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py

diff --git a/tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py b/tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py

index 96cceae715ef42e843b27c73ed424f69483e394a..ee318bd7a34e1c8f3427aceda7230932c96e13ce 100644

--- a/tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py

+++ b/tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py

@@ -4,21 +4,20 @@

import os

-from telemetry.core import discover

from telemetry.core import util

from telemetry.internal.platform import tracing_agent

from telemetry.internal.platform.tracing_agent import chrome_tracing_agent

from telemetry.timeline import trace_data as trace_data_module

from telemetry.timeline import tracing_category_filter

from telemetry.timeline import tracing_options

+from telemetry.util import classes_util

def _IterAllTracingAgentClasses():

tracing_agent_dir = os.path.join(

os.path.dirname(os.path.realpath(__file__)), 'tracing_agent')

- return discover.DiscoverClasses(

- tracing_agent_dir, util.GetTelemetryDir(),

- tracing_agent.TracingAgent).itervalues()

+ return classes_util.DiscoverClasses(

+ tracing_agent_dir, util.GetTelemetryDir(), tracing_agent.TracingAgent)

class TracingControllerBackend(object):