tools/perf/page_sets/__init__.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/init.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/__init__.py

diff --git a/tools/perf/page_sets/__init__.py b/tools/perf/page_sets/__init__.py

index 65daf2f00485efec7d5d1c81a30c17b8c9b5975b..d585f3271d79f6dee010f18099573ed618a7e5a7 100644

--- a/tools/perf/page_sets/__init__.py

+++ b/tools/perf/page_sets/__init__.py

@@ -6,14 +6,14 @@ import inspect

import os

import sys

-from telemetry.core import discover

from telemetry import story

+from telemetry.util import classes_util

# Import all submodules' PageSet classes.

start_dir = os.path.dirname(os.path.abspath(__file__))

top_level_dir = os.path.dirname(start_dir)

base_class = story.StorySet

-for cls in discover.DiscoverClasses(

- start_dir, top_level_dir, base_class).values():

+for cls in classes_util.DiscoverClasses(

+ start_dir, top_level_dir, base_class):

setattr(sys.modules[__name__], cls.__name__, cls)

« no previous file with comments | « tools/perf/measurements/measurement_smoke_test.py ('k') | tools/perf/profile_creators/profile_generator.py » ('j') | no next file with comments »

Unified Diff: tools/perf/page_sets/__init__.py

Unified Diff: tools/perf/page_sets/init.py