Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tools/telemetry/telemetry/benchmark_runner.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/profile_creators/profile_generator.py ('k') | tools/telemetry/telemetry/core/discover.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark_runner.py
diff --git a/tools/telemetry/telemetry/benchmark_runner.py b/tools/telemetry/telemetry/benchmark_runner.py
index eecb9458d71167fd755f8df30130ca1c303436c8..78253600c17f2cba4cc1edf6b8042333fedd8f77 100644
--- a/tools/telemetry/telemetry/benchmark_runner.py
+++ b/tools/telemetry/telemetry/benchmark_runner.py
@@ -14,11 +14,11 @@ import os
import sys
from telemetry import benchmark
-from telemetry.core import discover
from telemetry import decorators
from telemetry.internal.browser import browser_finder
from telemetry.internal.browser import browser_options
from telemetry.internal.util import command_line
+from telemetry.util import classes_util
def PrintBenchmarkList(benchmarks, possible_browser, output_pipe=sys.stdout):
@@ -264,10 +264,9 @@ def _MatchingCommands(string):
def _Benchmarks(environment):
benchmarks = []
for search_dir in environment.benchmark_dirs:
- benchmarks += discover.DiscoverClasses(search_dir,
+ benchmarks += classes_util.DiscoverClasses(search_dir,
environment.top_level_dir,
- benchmark.Benchmark,
- index_by_class_name=True).values()
+ benchmark.Benchmark)
return benchmarks
def _MatchBenchmarkName(input_benchmark_name, environment, exact_matches=True):
« no previous file with comments | « tools/perf/profile_creators/profile_generator.py ('k') | tools/telemetry/telemetry/core/discover.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698