Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Pass actual TestPlatform and OperatingSystem values to Suite. It's always been weird that a Suite has a string representation of its platform, and that that platform has no guarantee of actually reflecting the platform its metadata has been resolved against. This cleans that up. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/5efd46db2ece91f46ef6159acb1c5ee4468d379c

Patch Set 1 #

Patch Set 2 : Update pubspec. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -50 lines)			Patch
M	lib/src/backend/invoker.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/backend/metadata.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/backend/suite.dart	View		2 chunks	+50 lines, -19 lines	0 comments	Download
M	lib/src/runner/browser/browser_manager.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/runner/browser/iframe_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	lib/src/runner/load_suite.dart	View		5 chunks	+5 lines, -4 lines	0 comments	Download
M	lib/src/runner/loader.dart	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/runner/reporter/expanded.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/runner/vm/isolate_listener.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/runner/vm/isolate_test.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	lib/test.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/runner/browser/loader_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/runner/load_suite_test.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/runner/loader_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 5 months ago (2015-07-15 01:39:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5efd46db2ece91f46ef6159acb1c5ee4468d379c (presubmit successful).

Expand Messages | Collapse Messages