Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3407)

Unified Diff: lib/src/backend/metadata.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/invoker.dart ('k') | lib/src/backend/suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/backend/metadata.dart
diff --git a/lib/src/backend/metadata.dart b/lib/src/backend/metadata.dart
index f8791ca4a571705096fb39d54b995f2c96421177..0dc2d2922b849d70ee0b7db52a3755f2271fdc63 100644
--- a/lib/src/backend/metadata.dart
+++ b/lib/src/backend/metadata.dart
@@ -161,6 +161,8 @@ class Metadata {
/// Returns a copy of [this] with all platform-specific metadata from
/// [onPlatform] resolved.
Metadata forPlatform(TestPlatform platform, {OperatingSystem os}) {
+ if (onPlatform.isEmpty) return this;
+
var metadata = this;
onPlatform.forEach((platformSelector, platformMetadata) {
if (!platformSelector.evaluate(platform, os: os)) return;
« no previous file with comments | « lib/src/backend/invoker.dart ('k') | lib/src/backend/suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698