Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: test/runner/browser/loader_test.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pubspec.yaml ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/loader_test.dart
diff --git a/test/runner/browser/loader_test.dart b/test/runner/browser/loader_test.dart
index b4d9c5e725cd607231635d434396c41eee2150e9..b3210fa557755421c835da5c8701bc182d36dbce 100644
--- a/test/runner/browser/loader_test.dart
+++ b/test/runner/browser/loader_test.dart
@@ -60,7 +60,7 @@ void main() {
test("returns a suite with the file path and platform", () {
expect(suite.path, equals(p.join(_sandbox, 'a_test.dart')));
- expect(suite.platform, equals('Chrome'));
+ expect(suite.platform, equals(TestPlatform.chrome));
});
test("returns tests with the correct names", () {
@@ -131,9 +131,9 @@ Future main() {
try {
var suites = await loader.loadFile(path)
.asyncMap((loadSuite) => loadSuite.getSuite()).toList();
- expect(suites[0].platform, equals('VM'));
+ expect(suites[0].platform, equals(TestPlatform.vm));
expect(suites[0].path, equals(path));
- expect(suites[1].platform, equals('Chrome'));
+ expect(suites[1].platform, equals(TestPlatform.chrome));
expect(suites[1].path, equals(path));
for (var suite in suites) {
« no previous file with comments | « pubspec.yaml ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698