Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: lib/src/runner/loader.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/load_suite.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 56123f2353d3437fdf17fbac691f270b79306f93..cb28ab6a74c0363cf625a2abb5dfade5145fd38f 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -161,7 +161,7 @@ class Loader {
if (metadata.skip) {
yield new LoadSuite.forSuite(new Suite([
new LocalTest(path, metadata, () {})
- ], path: path, platform: platform.name, metadata: metadata));
+ ], path: path, platform: platform, metadata: metadata));
continue;
}
@@ -170,7 +170,7 @@ class Loader {
return platform == TestPlatform.vm
? _loadVmFile(path, metadata)
: _loadBrowserFile(path, platform, metadata);
- }, platform: platform.name);
+ }, platform: platform);
}
}
@@ -268,7 +268,8 @@ void main(_, Map message) {
}),
metadata: metadata,
path: path,
- platform: "VM",
+ platform: TestPlatform.vm,
+ os: currentOS,
onClose: isolate.kill);
_suites.add(suite);
return suite;
« no previous file with comments | « lib/src/runner/load_suite.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698