Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: lib/src/runner/browser/server.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/iframe_test.dart ('k') | lib/src/runner/load_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/server.dart
diff --git a/lib/src/runner/browser/server.dart b/lib/src/runner/browser/server.dart
index 1383bb3bc9e3423854a40b8b8d122639c22b8651..f2a3624cb7896f3ff5891be7db81107fee125ce9 100644
--- a/lib/src/runner/browser/server.dart
+++ b/lib/src/runner/browser/server.dart
@@ -297,15 +297,13 @@ void main() {
var browserManager = await _browserManagerFor(browser);
if (_closed) return null;
- var suite;
if (browserManager != null) {
- suite = await browserManager.loadSuite(path, suiteUrl, metadata,
+ var suite = await browserManager.loadSuite(path, suiteUrl, metadata,
mapper: browser.isJS ? _mappers[path] : null);
if (_closed) return null;
+ if (suite != null) return suite;
}
- if (suite != null) return suite.change(platform: browser.name);
-
// If the browser manager fails to load a suite and the server isn't
// closed, it's probably because the browser failed. We emit the failure
// here to ensure that it gets surfaced.
« no previous file with comments | « lib/src/runner/browser/iframe_test.dart ('k') | lib/src/runner/load_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698